Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove code from isHandling, but dont throw exception on non handling #26

Merged
merged 2 commits into from
Jun 17, 2018
Merged

remove code from isHandling, but dont throw exception on non handling #26

merged 2 commits into from
Jun 17, 2018

Conversation

h-bragg
Copy link
Contributor

@h-bragg h-bragg commented Jun 16, 2018

Resolves #25

When raygun handler is called first, isHandling only includes a record with ['level' => 100] (or whatever), thus exception and file/line checking does not happen.

@h-bragg h-bragg requested a review from brendankay June 17, 2018 00:45
@h-bragg
Copy link
Contributor Author

h-bragg commented Jun 17, 2018

This seems safe, we were never testing the exception, and it will just not send stuff to raygun

@h-bragg h-bragg merged commit 26ec6b4 into master Jun 17, 2018
@h-bragg h-bragg deleted the fix-raygun branch June 17, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankay brendankay Awaiting requested review from brendankay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@h-bragg